search

SUI-Components / sui

Monorepo for SUI (Simple User Interface) packages.
169 stars 33 forks source link

feat(packages/sui-react-web-vitals): rollback to log targets with empty values again #1736

Closed nucliweb closed 3 weeks ago

nucliweb commented 6 months ago

Description

The empty values are a bug of the library, in principle, we eliminate them for not sending them to Open Search, and eliminate noise, but not having the target empties gives us a distortion of the real percentages of the attributions, and that is why we resubmit them.

nucliweb commented 6 months ago

how's that? TBH I didn't really get why wouldn't we log those empty values...

The empty values are a bug of the library, in principle, we eliminate them for not sending them to Open Search, and eliminate noise, but not having the target empties gives us a distortion of the real percentages of the attributions, and that is why we resubmit them.

I just added the explanation as a description in the the PR 😜

jordevo commented 6 months ago

how's that? TBH I didn't really get why wouldn't we log those empty values...

The empty values are a bug of the library, in principle, we eliminate them for not sending them to Open Search, and eliminate noise, but not having the target empties gives us a distortion of the real percentages of the attributions, and that is why we resubmit them.

I just added the explanation as a description in the the PR 😜

that's what I thought in the first place... if we were to remove empty values, there'd be an overrepresentation of the elements that get their attribution and name correctly