search

SUMup-database / SUMup-example-scripts

This repository contains scripts that can read, process and plot the SUMup 2023 dataset.
0 stars 1 forks source link

Missing profile name for some cores #1

Open jullienn opened 8 months ago

jullienn commented 8 months ago

Hi SUMup team,

I spotted that some profiles name are missing in the 'SUMup_2023_density_greenland.nc' file. For example, firn cores drilled by Rennermalm et al., (2021) store 'NA' in the 'profile_name' column, although the profiles name are present in the original files (data published together with the latter paper). Is this something that can be fixed?

Cheers, Nicolas

BaptisteVandecrux commented 8 months ago

Hi Nico,

Since SUMup 2022 did not save the profile names, only a profile key, that information got lost. I agree that it is an important information to give. I have added it for all profiles added in the 2023 update and for some profiles that I have identified manually in the 2022 file.

It would be great if you could help me to find the original names of the profile saved in the previous SUMup version.

This is done through in this file which links the 2022 profile keys to a name. Please update this file and submit it in a pull request.

Maybe @MeganTM can confirm whether there is a way to recover that info from her 2022 processing scripts?

jullienn commented 8 months ago

Hi Baptiste,

I do not have access to the file you mentioned, could you make it available please? I have performed the identification of the profile_key for the cores in Rennermalm et al., (2021).

Nico

BaptisteVandecrux commented 8 months ago

Hi Nico,

I have invited you as a collaborator to the main SUMup 2023 repo. Once you accept the invite, you should be able to access: https://github.com/SUMup-database/SUMup-2023/blob/main/data/SUMup%202022/SUMup_density_2022_profile_names.csv , modify it and submit a revised version as a PR.

I also had a look at the Harper cores you mentioned and indeed the 2022 cores were added but not the 2018-2019 ones. I am correcting that. Thanks for spotting it!

MeganTM commented 8 months ago

Hi all,

Apologies for my delayed reply. I have the profile names from previous SUMup releases and can help with incorporating them back into the database. This was an oversight in the 2022 release but can definitely be remedied. I will put it on my to-do list for this week and keep you posted.

Megan

On Mon, Oct 23, 2023 at 7:31 AM Baptiste Vandecrux @.***> wrote:

Hi Nico,

I have invited you as a collaborator to the main SUMup 2023 repo. Once you accept the invite, you should be able to access: https://github.com/SUMup-database/SUMup-2023/blob/main/data/SUMup%202022/SUMup_density_2022_profile_names.csv , modify it and submit a revised version as a PR.

I also had a look at the Harper cores you mentioned and indeed the 2022 cores were added but not the 2018-2019 ones. I am correcting that. Thanks for spotting it!

— Reply to this email directly, view it on GitHub https://github.com/SUMup-database/SUMup-example-scripts/issues/1#issuecomment-1774992704, or unsubscribe https://github.com/notifications/unsubscribe-auth/APXLXIORAWVJZCWKHJNGUJTYAZIRPAVCNFSM6AAAAAA6FZBC6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUHE4TENZQGQ . You are receiving this because you were mentioned.Message ID: @.***>