search

SUNET / sri-front

Frontend code for the SRI project
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Ports: Used By table #235

Open jlguillen opened 3 years ago

jlguillen commented 3 years ago

Ports - Missing "Port is used by", Should be 'filterable'.

mariahaider commented 3 years ago

The 'Used by' Services have two tabs, 'Services' and 'Direct'. In SRI, only 'Direct' Service is shown. The 'Services' show all the types for example, 'customer' and 'backbone' services.

Screenshot 2021-01-21 at 13 44 31

I did a bit of back search and found that the service that is not listed does not actually have that port under dependency but have double entries of the 'Units'.

Screenshot 2021-01-21 at 13 50 03

I can explain in a video session if it sounds complicated :)

mariahaider commented 3 years ago

I could not filter the 'Port used by' table with strings from 'Description'.

mariahaider commented 3 years ago

It is not fixed.

PaKZer0 commented 3 years ago

@mariahaider says:

Ports - they do not need 'service' 'optical path' etc filters Screenshot 2021-01-25 at 16 02 22

PaKZer0 commented 3 years ago

@mariahaider but I don't understand, this pill filter by entity is present in NOCLook, isn't it used anymore? Screenshot_2021-01-26 NOCLook

PaKZer0 commented 3 years ago

@mariahaider Btw, besides the entity pills/tabs, the input filter can filter by description, it will be delivered with the next tag.

mariahaider commented 3 years ago

I see only 'Direct' and 'Services' in our NI. @johanlundberg is this functionality 'hidden'?

PaKZer0 commented 3 years ago

AFAIK in the code the same table template is used for all "used by" tables, it shows the different tabs if there's any element to list.

mariahaider commented 3 years ago

ok, then in SRI, we see them all the time.

PaKZer0 commented 3 years ago

So then what we should do is to show only filtering pills of the entities related with the entity for all Used by tables

PaKZer0 commented 3 years ago

We've been thinking about this requested change with the pills; we can't hide any because then the user won't be able to add new related entities.

The pills filter the table, but also allows the user to search existing entities of that type or create a new one in a modal window, and then link the selected entity to the main entity (a port in this case).

So showing/hiding these on an entity basis (for example, show only Services and Optical Links for Ports used by table, or show only Services for Cables used by table) will require to define this configuration somewhere (a file or database) and will skid this issue out of its point.

My suggestion would be to add another issue about defining which pills should be visible/hidden for table/entity and closing this one as the table and the filter are already there.

mariahaider commented 3 years ago

ok, but what about the problems that I mentioned that i cannot search with 'description'? And then some of the services have duplicate ports, the ones that are not listed in 'Port used by' table.

PaKZer0 commented 3 years ago

Sorry, what I meant that for the next release the filter and the table will be ready for your validation.

What I don't understand is what you meant with the duplication of ports, if you find it helpful we can do a quick meeting in order to understand this.

mariahaider commented 3 years ago

sure, let me know in the sri channel. I don't check the github comments regularly.