search

SUNET / sri-front

Frontend code for the SRI project
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Router: Used by table #295

Open PaKZer0 opened 3 years ago

PaKZer0 commented 3 years ago

Router is used by' is missing. No need to have 'Optical path' 'Optical Multiplex' etc tabs

PaKZer0 commented 3 years ago

@mariahaider The table is present in SRI and it works like it's NOCLook counterpart:

Screenshot_2021-01-26 NOCLook Detail

Screenshot_2021-01-26 SRI

Should we remove the filters because they aren't used anymore?

mariahaider commented 3 years ago

Ok, I made a slight mistake, they do show 'optical paths', but not the others. What about 'direct', how it is going to be shown?

PaKZer0 commented 3 years ago

Since we dont' have the real data, we have no clue about which entities are going to be shown in which table, besides what the code expects to handle. So we know that Optical Paths are displayed, but the code also handle the other entities like OMS, Service and Optical Links.

In the other hand, we've replaced 'Direct' with 'All' because according to our interpretation of the code, there is listed all the entities that are listed in each tab, but we might have missed the point.

mariahaider commented 3 years ago

ah, ok, i think in that case, it shoud be 'direct', 'All' is actually ' all services'.

PaKZer0 commented 3 years ago

We've found out that we had a difference with SRI used by table with NOCLook counterpart: In SRI we only list direct dependents nodes (those which are directly connected) but NOCLook lists the dependents of the dependents.

For example If a OMS is used by a Service, and a Router uses an Optical Link and this Service, SRI will only list the Optical Link and the Service, but it won't show the OMS, but NOCLook would do it.

So if you agree, we might add a new ticket to change "All" to "Direct" and also change which used by elements are displayed to match the NOCLook results.

mariahaider commented 3 years ago

Yes, please do that :)