search

SUNET / te-canvas

0 stars 1 forks source link

Investigate if `return_types` is needed in `TimeEdit.find_reservations_all` #11

Closed ernstwi closed 1 year ago

ernstwi commented 2 years ago

The function find_reservations_all uses the api endpoint findReservations, which takes an argument return_types. This specifies what types of objects (attached to each reservation) we want to get.

This is the cause of a lot of code surrounding event template strings. So it would be a big opportunity for simplification if there was a way to simply get all objects. I am pretty sure I looked into this and found that there was not, but we should double check this.

pnts-se commented 1 year ago

A lot of the code surrounding template strings is removed since the users choose fields via interactive ui. return_types is also a good thing since it avoids over-fetching.