Closed Cxarli closed 7 years ago
Hi! thank you for your contribution once again. We will check and see if this is needed. The idea of having it centralized in a travis.yml
with a declarative language sounded good enough, without being required to add a shell script. We well think about it though. Could you check what is happening with the builds in any case?
Thanks!
Whoops, made a typo. Should be fixed :smile: My foremost reason for putting it in a shell script, is that you can run a linter over the code to see if something is wrong with it.
Another (small) benefit is that you can specify a shebang (#!/bin/bash
) to indicate the shell, to fix edge cases where someone would use the travis script on a csh-based shell (Even though that's highly unlikely)
Merging #131 into develop will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## develop #131 +/- ##
========================================
Coverage 53.65% 53.65%
========================================
Files 6 6
Lines 2479 2479
========================================
Hits 1330 1330
Misses 1149 1149
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e4ede67...72ab4d6. Read the comment docs.
Can't get enough of this project, so here's another PR. Not really an issue, but I thought it would be nice :smile: