SUPERAndroidAnalyzer / super

Secure, Unified, Powerful and Extensible Rust Android Analyzer
https://superanalyzer.rocks/
GNU General Public License v3.0
421 stars 59 forks source link

Documentation of `utils.rs` #57

Open Razican opened 8 years ago

Razican commented 8 years ago

Most of the code is still not documented. This is the tracking issue for utils.rs file documentation.

iamdharmveer commented 8 years ago

I can do this for you 👍

Razican commented 8 years ago

@iamdharmveer wow! great, thanks!! :smiley:

iamdharmveer commented 8 years ago

Can you give me more details about the documentation 👍

Razican commented 8 years ago

For getters and setters, a small (even one line) explanation on the parameter they get and set would be enough. For constants, their function (in this case, PARSER_CONFIG is the parser configuration used for the XML parser).

Function descriptions should show what functions do, in this case, print_error() and print_warning() are used for errors and warnings of the analysis process itself, and they color them on stdout in different colors.

A good example of a documentation can be found in this crate.

iamdharmveer commented 8 years ago

All changes in documentation.md Because I didn't found utils.rs so I'm asking about which file do you want to change ?

iamdharmveer commented 8 years ago

Ok thank you 👍

Razican commented 8 years ago

Nope, files are relative to the src/ folder. So in this case, it would be the src/utils.rs file, and the documentation would need to be created using the Rust documentation format.

iamdharmveer commented 8 years ago

One more query if I want to join your organization how can it's happen 😄

Razican commented 8 years ago

Well, that is something that would happen with enough pull requests from you :) if you manage to get many pull requests merged in SUPER, you would probably become a collaborator, and after some time, a full member of the team :)

iamdharmveer commented 8 years ago

Thank You 😄 👍