search

SUPERAndroidAnalyzer / super

Secure, Unified, Powerful and Extensible Rust Android Analyzer
https://superanalyzer.rocks/
GNU General Public License v3.0
421 stars 59 forks source link

Use `PathBuf` for paths instead of `String` #70

Closed aomader closed 8 years ago

aomader commented 8 years ago

Fixes #52

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 28.439% when pulling 4a69156db8d664da898e52cea31aefff65c0d364 on b52:master into a6d6beea7ea33e9f3195723400b63fcfcb16eb6e on SUPERAndroidAnalyzer:master.

aomader commented 8 years ago

@Razican I fixed everything except for two clones, which are not really removable.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 28.439% when pulling 3ffbdb24922b439c171ff7f4c69c726a57d51fcf on b52:master into a6d6beea7ea33e9f3195723400b63fcfcb16eb6e on SUPERAndroidAnalyzer:master.

Razican commented 8 years ago

Looks really good! still waiting for Travis to pass the OSX builds (seems they are having some issues). As soon as they pass, I'll merge. Thanks for your work!

Razican commented 8 years ago

Just a small thing: I had to change the base branch of the merge to develop, as said in contributing.md, we only accept pull requests to the develop branch. Could you rebase?

aomader commented 8 years ago

Done

Razican commented 8 years ago

Cool! As soon as tests pass I'll merge. Thanks!

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 28.415% when pulling aef398b2c57fa7786b6588e1590defa6be0a65dd on b52:master into a6d6beea7ea33e9f3195723400b63fcfcb16eb6e on SUPERAndroidAnalyzer:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 28.513% when pulling 1e78e1a11b3cedf703ca520d5923488e1800ebda on b52:master into 33ebc152d96e3780ec8a5d547b8ace8c9a16835f on SUPERAndroidAnalyzer:develop.