search

SUPERCILEX / Robot-Scouter

:robot: Easy, efficient, and collaborative FIRST robot scouting
https://bit.ly/RobotScouter
GNU General Public License v3.0
107 stars 41 forks source link

Add dependency locking #220

Closed SUPERCILEX closed 6 years ago

SUPERCILEX commented 6 years ago

https://docs.gradle.org/4.8/release-notes.html#locking-of-dynamic-dependencies

SUPERCILEX commented 6 years ago

The point of this issue is enabling the use of dynamic dependencies for debug builds while keeping known versions for release builds. However, Gradle isn't actually that smart about finding the latest dependencies. Therefore, a smart version checker was added in https://github.com/SUPERCILEX/Robot-Scouter/commit/e0a18e7df0dbf2cec7431030baf16e417260cf0d#diff-392475fdf2bc320d17762ed97109a121 and will sufice.

SUPERCILEX commented 6 years ago

Apparently it was a bug: https://github.com/gradle/gradle/issues/6102

SUPERCILEX commented 6 years ago

Actually, adding dynamic dependencies slows down the build... so nah.