SUPERCILEX / fuc

Modern, performance focused unix commands
Apache License 2.0
340 stars 8 forks source link

Add a progressbar or copy-paste speed #38

Closed krakotay closed 2 months ago

krakotay commented 2 months ago

When I measure, i can see a fantastic improve of speed, but it will be much more beautiful, if user can see speed of copying image

SUPERCILEX commented 2 months ago

This was discussed in https://github.com/SUPERCILEX/fuc/issues/14 and is now documented: https://github.com/SUPERCILEX/fuc/commit/95a2678b991e65b6d916c69131b3e80267a3f88c

krakotay commented 2 months ago

This was discussed in #14 and is now documented: 95a2678

image that's strange. I can't see --progress with cpz -h, and cpz --progress makes an Error. When I use just cpz from to, there aren't any difference between vanilla cpz and cpz with progress feature

SUPERCILEX commented 2 months ago

Nope, you need to install the binary again but with the progress feature. It's not a flag in the binary itself.

SUPERCILEX commented 2 months ago

Oh, just saw you tried reinstalling. Use --force as it suggests.

krakotay commented 2 months ago

Oh, just saw you tried reinstalling. Use --force as it suggests.

image And... nothing changes. All works excluding progress bar

SUPERCILEX commented 2 months ago

There's no progress flag. Now the binary will always show progress.

krakotay commented 2 months ago

There's no progress flag. Now the binary will always show progress.

But there aren't, even with large number of files. For example, in my screenshot I successfully copied windows folder to another folder. I works perfect and fantastic speed, but without progress bar image

SUPERCILEX commented 2 months ago

Hmmm, how long does the copying take? If less than a second, you probably won't see the progress, but it should definitely be visible with longer copies. Though it's also possible that this is just broken on Windows? I'm not sure.

krakotay commented 2 months ago

Hmmm, how long does the copying take? If less than a second, you probably won't see the progress, but it should definitely be visible with longer copies. Though it's also possible that this is just broken on Windows? I'm not sure.

3 or 4 seconds. Btw, default windows cp used more than 600 seconds xD

krakotay commented 2 months ago

Hmmm, how long does the copying take? If less than a second, you probably won't see the progress, but it should definitely be visible with longer copies. Though it's also possible that this is just broken on Windows? I'm not sure.

I tried with measurements, cpz copying takes 19 sec (compare to 656 with default cp)

SUPERCILEX commented 2 months ago

Ohhhh, hold on I'm stupid there's no logging on non-Linux builds.

krakotay commented 2 months ago

Ohhhh, hold on I'm stupid there's no logging on non-Linux builds.

well, in Linux all works. It's unusual progress info btw =) Without copy speed or progress-bar image, just something like this one

SUPERCILEX commented 2 months ago

Ok, can you try cargo install cpz --features progress --force --git https://github.com/SUPERCILEX/fuc

krakotay commented 2 months ago

Ok, can you try cargo install cpz --features progress --force --git https://github.com/SUPERCILEX/fuc

image well, even i tried to build locally, i have this one. just with -F progress

SUPERCILEX commented 2 months ago

Well this is icky, I guess the tracing attribute doesn't support cfg-ed args. Can you try installing again? Should be fixed.

krakotay commented 2 months ago

image nothing changed

SUPERCILEX commented 2 months ago

Oh for that you just need to do cargo +nightly ... and rustup install nightly if you don't have it.

krakotay commented 2 months ago

Thank you, all works!

SUPERCILEX commented 2 months ago

Yay!

krakotay commented 1 month ago

Yay! btw, progress bar in rmz doesn't work... image

SUPERCILEX commented 1 month ago

Yeah, Windows progress support isn't going to be implemented because we use https://github.com/XAMPPRocky/remove_dir_all. Honestly not sure what that lib does extra so maybe I could just use rmz's non-linux implantation on Windows? Don't know.