SUPERCILEX / gnome-clipboard-history

Gnome Clipboard History is a clipboard manager Gnome extension that saves what you've copied into an easily accessible, searchable history panel.
https://extensions.gnome.org/extension/4839/clipboard-history/
MIT License
473 stars 47 forks source link

Weird behaviour of shortcut setting #112

Open Pheggas opened 2 years ago

Pheggas commented 2 years ago

Describe the bug

When i want to set a shortcut, it shows "New acceleration..." instead of shortcut key combination that i pressed.

How To Reproduce

  1. Install extension
  2. Go to shortcuts section (at the bottom)
  3. Find "Toggle the menu" and doubleclick on pre-set shortcut combination to change it
  4. Press any key / combination
  5. Still see "New acceleration..."
  6. If kept, UI is frozen and cannot be closed

Versions

GNOME Shell 42.5
GCH   Version: 21
org.gnome.shell.extensions.clipboard-history cache-only-favorites false
org.gnome.shell.extensions.clipboard-history cache-size 100
org.gnome.shell.extensions.clipboard-history clear-history @as []
org.gnome.shell.extensions.clipboard-history confirm-clear true
org.gnome.shell.extensions.clipboard-history disable-down-arrow true
org.gnome.shell.extensions.clipboard-history display-mode 0
org.gnome.shell.extensions.clipboard-history enable-keybindings true
org.gnome.shell.extensions.clipboard-history history-size 1000
org.gnome.shell.extensions.clipboard-history move-item-first true
org.gnome.shell.extensions.clipboard-history next-entry @as []
org.gnome.shell.extensions.clipboard-history notify-on-copy false
org.gnome.shell.extensions.clipboard-history paste-on-selection true
org.gnome.shell.extensions.clipboard-history prev-entry @as []
org.gnome.shell.extensions.clipboard-history private-mode false
org.gnome.shell.extensions.clipboard-history process-primary-selection false
org.gnome.shell.extensions.clipboard-history strip-text false
org.gnome.shell.extensions.clipboard-history toggle-menu ['<Super><Shift>V']
org.gnome.shell.extensions.clipboard-history toggle-private-mode ['<Super><Shift>P']
org.gnome.shell.extensions.clipboard-history topbar-preview-size 1
org.gnome.shell.extensions.clipboard-history window-width-percentage 33

Steps to repro

What causes the crash/bug? I'm not sure. I'm on Fedora 36 (Workstation Edition) with Gnome 42.5 and Wayland.

Additional context (if a crash, provide stack trace)

Add any other context about the problem here.

SUPERCILEX commented 2 years ago

That's code I haven't really touched. It looks like we just use Gtk's implementation: https://github.com/SUPERCILEX/gnome-clipboard-history/blob/abeab9579733586bc165fe1f69fd612320dd9eb9/prefs.js#L363 No idea what could be causing that, sorry.

Pheggas commented 2 years ago

I wrote this same issue on original repo. We'll see what will the dev reply.