search

SUPERCILEX / gnome-clipboard-history

Gnome Clipboard History is a clipboard manager Gnome extension that saves what you've copied into an easily accessible, searchable history panel.
https://extensions.gnome.org/extension/4839/clipboard-history/
MIT License
470 stars 46 forks source link

Extension doesn't cooperate with a password manager #175

Closed 3hr80FEZwlir closed 4 months ago

3hr80FEZwlir commented 4 months ago

Describe the bug

Entries copied from a password manager stay there permanently even though they should be purged from history by the password manager.

How To Reproduce

  1. Try out KeePassXC or Secrets password managers.
  2. Make sure that the feature of clearing copied clipboard entry is on.
  3. Copy some field.
  4. See that copied content stays in Clipboard History extension permanently.

Versions

GNOME Shell 46.2 GCH Version: 42 org.gnome.shell.extensions.clipboard-history cache-only-favorites false org.gnome.shell.extensions.clipboard-history cache-size 1000 org.gnome.shell.extensions.clipboard-history clear-history @as [] org.gnome.shell.extensions.clipboard-history confirm-clear true org.gnome.shell.extensions.clipboard-history disable-down-arrow true org.gnome.shell.extensions.clipboard-history display-mode 0 org.gnome.shell.extensions.clipboard-history enable-keybindings true org.gnome.shell.extensions.clipboard-history history-size 10000 org.gnome.shell.extensions.clipboard-history move-item-first true org.gnome.shell.extensions.clipboard-history next-entry @as [] org.gnome.shell.extensions.clipboard-history notify-on-copy false org.gnome.shell.extensions.clipboard-history paste-on-selection false org.gnome.shell.extensions.clipboard-history prev-entry @as [] org.gnome.shell.extensions.clipboard-history private-mode false org.gnome.shell.extensions.clipboard-history process-primary-selection false org.gnome.shell.extensions.clipboard-history strip-text true org.gnome.shell.extensions.clipboard-history toggle-menu ['v'] org.gnome.shell.extensions.clipboard-history toggle-private-mode @as [] org.gnome.shell.extensions.clipboard-history topbar-preview-size 10 org.gnome.shell.extensions.clipboard-history window-width-percentage 33

Additional context (if a crash, provide stack trace)

Both apps can clear "their" clipboard entry if the extension isn't used.

SUPERCILEX commented 4 months ago

You need to turn on private mode while copying passwords so that the extension stops listening for clipboard changes.

3hr80FEZwlir commented 4 months ago

Um... I wish your words would suggest a temporary workaround... but it doesn't sound like it's the case.

Taking into an account that a password manager is usually a must for people with more than few accounts - assuming they care about their privacy (among other things not using browser's built-in password manager) - and the amount of people with password managers will only increase, it's strange that it's an issue at all.

So I understand that there is no intention to fix it?

SUPERCILEX commented 4 months ago

I wish your words would suggest a temporary workaround

I literally just did.

3hr80FEZwlir commented 4 months ago

Temporary...? So the issue will be fixed? Then why close it as completed?

SUPERCILEX commented 4 months ago

I doubt this will be fixed. I don't know what KeePass is doing, but I'm guessing they're setting the clipboard to an empty value? We could interpret that as "delete the last entry" but I'm pretty sure it happens in non password cases too so deleting random entries would be bad.

I'd accept a PR to be compatible with KeePass whatever that means as long as it doesn't break other functionality. But I'm personally not going to look into this.

3hr80FEZwlir commented 4 months ago

That's sad. Well, thanks for the answer anyway.

SUPERCILEX commented 4 months ago

Since you're using KeePass, you might be interested in https://github.com/SUPERCILEX/gnome-clipboard-history/pull/170