search

SUPScientist / smart-coasts-bathy-mapping

Low-cost, open-source bathymetric mapping (depth, GPS, angle, datalogging)
MIT License
0 stars 7 forks source link

Create depth-sensing-JSN-SRO4_Gen3_RK-SD-GPS-temp-integration-attempt1 #5

Closed indugadiraju closed 11 months ago

indugadiraju commented 1 year ago

I have copied my code into this file! I attempted to integrate the JSN-SRO4_Gen3_RK code with the preexisting code, but I'm not sure that it will fully work. My computer is having some issues with Visual Studio Code, so I'm not able to flash the code there. I tried the Particle Workbench Web IDE, but you have to have a device to compile/flash the code, so I haven't been able to compile the code and check for any specific errors yet. Please let me know if there are any errors or issues that arise with the code! Thank you!!

SUPScientist commented 1 year ago

Reopening this PR as it is my impression that you want me to review for consideration for integration with current main code branch, right? I will review the PR and commit as soon as possible. Thanks!

indugadiraju commented 11 months ago

Hi Dr. B! I tried to update the code with the commented changes! However, I can't compile on VS Code on my laptop, so I'm not sure if the code is completely bug-free! Thank you!

SUPScientist commented 11 months ago

Great! I'll take a look...

SUPScientist commented 11 months ago

@InduGadi, it doesn't look like you committed your most recent changes, or at least I don't see them here. Can you check on your side and make sure you've committed the most recent changes or help me find them if you have committed and put them up on GitHub?

SUPScientist commented 11 months ago

Closing in favor of https://github.com/SUPScientist/smart-coasts-bathy-mapping/pull/6