SURAJTHEGREAT / dockerpymongowebframework

To containerize python application using docker
https://pythontutorials.quora.com
0 stars 0 forks source link

Why extra .env required when all env files are available in conf folder #2

Closed SURAJTHEGREAT closed 5 years ago

SURAJTHEGREAT commented 6 years ago

Could observe that proxy details needs to be passed in .env file - while proxy details are already provided in the conf/proxy.env.

Why there is a rework?

SURAJTHEGREAT commented 6 years ago

Yeah accepted the issue. Will work on that to eliminate.

SURAJTHEGREAT commented 5 years ago

Steps to reproduce:

  1. Dont create .env file to fill proxy details.
  2. After make env command - fill in dummy proxy variables
  3. On docker build - check if takes the entered proxy details
SURAJTHEGREAT commented 5 years ago

This is not the right fix , as proxy needs to be given. It is to be noted that proxy given is build time argument and conf/proxy.env is for runtime,