SURFnet / rd-sram-integration

Research Drive / SURF Research Access Management Integration
2 stars 3 forks source link

malfunction on repetitive OCM invite calls #153

Closed soltanireza65 closed 1 year ago

soltanireza65 commented 1 year ago
MariaDB [efss]> select * from oc_share_external_group;
+----+--------+------------+-----------------------------------------------------------------+-----------+-----------------+----------+-------+----------+-------------+-------------------------------------+----------------------------------+----------+------------+
| id | parent | share_type | remote                                                          | remote_id | share_token     | password | name  | owner    | user        | mountpoint                          | mountpoint_hash                  | accepted | lastscan   |
+----+--------+------------+-----------------------------------------------------------------+-----------+-----------------+----------+-------+----------+-------------+-------------------------------------+----------------------------------+----------+------------+
|  5 |   NULL |          7 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | federalists | {{TemporaryMountPointName#/flll}}   | 07d065871026cc608e31f9e80bdf93b3 |        0 | 1683186996 |
|  6 |      5 |          6 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | marie       | {{TemporaryMountPointName#/flll}}   | 07d065871026cc608e31f9e80bdf93b3 |        0 | 1683186996 |
|  7 |   NULL |          7 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | federalists | {{TemporaryMountPointName#/flll}}-1 | 13ebaaf1e189251af4c493acd7ee2adf |        0 | 1683187213 |
|  8 |      7 |          6 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | fed_user_1  | {{TemporaryMountPointName#/flll}}-1 | 13ebaaf1e189251af4c493acd7ee2adf |        0 | 1683187213 |
|  9 |      7 |          6 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | marie       | {{TemporaryMountPointName#/flll}}-1 | 13ebaaf1e189251af4c493acd7ee2adf |        0 | 1683187213 |
+----+--------+------------+-----------------------------------------------------------------+-----------+-----------------+----------+-------+----------+-------------+-------------------------------------+----------------------------------+----------+------------+

while calling a OCM invite (for same file and same group) we should address existing share records in oc_share_external_group. and just consider the possible new group members

and this should be the desired table output:

MariaDB [efss]> select * from oc_share_external_group;
+----+--------+------------+-----------------------------------------------------------------+-----------+-----------------+----------+-------+----------+-------------+-------------------------------------+----------------------------------+----------+------------+
| id | parent | share_type | remote                                                          | remote_id | share_token     | password | name  | owner    | user        | mountpoint                          | mountpoint_hash                  | accepted | lastscan   |
+----+--------+------------+-----------------------------------------------------------------+-----------+-----------------+----------+-------+----------+-------------+-------------------------------------+----------------------------------+----------+------------+
|  5 |   NULL |          7 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | federalists | {{TemporaryMountPointName#/flll}}   | 07d065871026cc608e31f9e80bdf93b3 |        0 | 1683186996 |
|  6 |      5 |          6 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | marie       | {{TemporaryMountPointName#/flll}}   | 07d065871026cc608e31f9e80bdf93b3 |        0 | 1683186996 |
|  7 |      5 |          6 | https://81-pondersource-devstock-tfcffv42pmm.ws-eu96b.gitpod.io | 3         | C5HY0qTLkZ8TNFh |          | /flll | einstein | fed_user_1  | {{TemporaryMountPointName#/flll}}-1 | 13ebaaf1e189251af4c493acd7ee2adf |        0 | 1683187213 |
+----+--------+------------+-----------------------------------------------------------------+-----------+-----------------+----------+-------+----------+-------------+-------------------------------------+----------------------------------+----------+------------+
yasharpm commented 1 year ago

Fixed in this commit.