SURFnet / rd-sram-integration

Research Drive / SURF Research Access Management Integration
2 stars 3 forks source link

how to distinguish between default group backend and federated group backends? #178

Closed soltanireza65 closed 1 year ago

soltanireza65 commented 1 year ago

first of all: we should all agree that all the groups on all tables should be unique,

by default, ownCloud just has one group-type, and the default groupManager class will return just the default group type. also, we know that the getBackend method of the default group returns the first index of the registered backends array but now that we have a second type of group ('fg-group') when the group manager tries to get the group, it should be able to assign the correct backend to the given group.

working on this in: https://github.com/SURFnet/rd-sram-integration/tree/new-group-backend

michielbdejong commented 1 year ago

You can look at how the customgroups app does this. I think they prepend something like customgroup_ to the beginning of the group name at the group manager level. I'll see if I can find the link to the code.

michielbdejong commented 1 year ago

Right, it's here: https://github.com/owncloud/customgroups/blob/6a5a1a57dd8c926df3b28dee654f6655bb5ae3a9/lib/CustomGroupsBackend.php#L194

michielbdejong commented 1 year ago

This is a question you're posing in relation to #180, right?

soltanireza65 commented 1 year ago

we have fixed it in https://github.com/SURFnet/rd-sram-integration/pull/185