search

SURFnet / rd-sram-integration

Research Drive / SURF Research Access Management Integration
2 stars 3 forks source link

Check that resharing works properly for federated groups #202

Open thepeak99 opened 1 year ago

thepeak99 commented 1 year ago

Add tests if not present.

thepeak99 commented 1 year ago

View #52

navid-shokri commented 1 year ago

So I checked the workflow and ensured that reshare was performed by the same flow as sharing.

1- https://github.com/pondersource/core/blob/049b9a88173dd67219f4670097726563e8305046/apps/files_sharing/lib/Controller/Share20OcsController.php#L371C2-L371C2

2- https://github.com/pondersource/core/blob/049b9a88173dd67219f4670097726563e8305046/apps/files_sharing/lib/Controller/Share20OcsController.php#L584

3- https://github.com/pondersource/core/blob/049b9a88173dd67219f4670097726563e8305046/lib/private/Share20/Manager.php#L832

4- reshare workflow will be detected in federated share provider in: https://github.com/pondersource/core/blob/049b9a88173dd67219f4670097726563e8305046/apps/federatedfilesharing/lib/FederatedShareProvider.php#L182

So, in MixShareProvider we are using the DefaultShareProvider Base class and there is no reshare concept (reshare notification is defined in open cloud mesh protocol).

also, in the openCloudMesh app, we are using FederatedShareProvider (AbstractShareProvider) as our code base and its behavior is untouched