SURFnet / rd-sram-integration

Research Drive / SURF Research Access Management Integration
2 stars 3 forks source link

Not clear which owncloud/core branch to use #210

Closed michielbdejong closed 1 year ago

michielbdejong commented 1 year ago

In dev-stock we're using ocm-cleaning: https://github.com/pondersource/dev-stock/blob/3fcf168/scripts/init-rd-sram.sh#L7 But https://github.com/owncloud/core/pull/40589 uses the accept-ocm-to-groups branch.

Which one is correct?

navid-shokri commented 1 year ago

So we are using this oc-opencloudmesh-testing branch to build and create our testing environment. I mentioned it in this part of the documentation. https://github.com/SURFnet/rd-sram-integration#testing-environment

michielbdejong commented 1 year ago

@navid-shokri thanks for reporting that apart from unclarity about which branch of owncloud/core to use, there is also unclarity about which branch of `dev-stock to use, let's fix that!

I'm not creating a separate break-out issue about that, because the answer is pretty simple:

We should all be using themain branch of dev-stock, always.

For that issue in the context of milestone 1.2, see #211 For that issue in the context of milestone 1.1, I already updated the docs (testing this myself now) - https://github.com/pondersource/oc-opencloudmesh/commit/ab0c0a830f2a2119113db092c39f375c42f32736

So OP question remains:

navid-shokri commented 1 year ago

So, we were working on oc-opencloudmesh-testing branch of the dev-stock from the beginning of that. I can remember you told us to use that branch and there was no newer update for us. so we continued using mentioned branch until now.

according to the this (file)[https://github.com/pondersource/dev-stock/blob/oc-opencloudmesh-testing/scripts/init-rd-sram.sh]

we are using these branches for each repository: 1- owncloud core --> accept-ocm-to-groups 2- rd-sram (federated groups) --> main 3- oc-opencloudmesh --> main

I used this and it was updated and functional for our development. If we Should using the main branch it was not told to me at least and so I documented my process and let others review my documentation and no one raised any claim. So It seems all of us were on the same page except you.

thepeak99 commented 1 year ago

Ok so lets leave dev-stock for a second, let's find out what are the differences between ocm-cleaning and accept-ocm-to-groups and merge them into one. @navid-shokri

michielbdejong commented 1 year ago

OK in the meantime I'll test to what extent the opencloudmesh app works with the current state of accept-ocm-to-groups

michielbdejong commented 1 year ago

We're not fully on accept-ocm-to-groups.

If you find anything missing from that branch then you can add it there, but for now it seems to be mostly working.