SURFnet / sp-dashboard

SURFconext Service Provider Dashboard
Apache License 2.0
5 stars 2 forks source link

Type of service field is emptied when a non existing value is already present in manage #1322

Open quartje opened 4 days ago

quartje commented 4 days ago

In https://github.com/SURFnet/sp-dashboard/pull/646 and https://github.com/SURFnet/sp-dashboard/pull/648 and new Manage field was introduced. While the functionality works, some edge cases do not: There are some types which we have in Manage, but which should not be presented to customers. We can leave it out from the json where we define the types but that gives the following bug:

In manage, have an entity which has a "type" that is not present in the json. In spdashboard, edit the entity (just have a change, like name) The result is pushed back to manage, but the type of service is emptied.

Proposed solution: In the attributes json in the assets, we have the option to define an attribute that exists, but should not be shown in the dashboard using the excludeOnEntityType attribute. Maybe we can use that mechanism here as well?