search

SURFscz / SBS

Samenwerking Beheer Systeem ↣ Collaboration Management System
Apache License 2.0
3 stars 2 forks source link

Show a modal when a user tries to accept an already accepted invitation #1345

Closed mrvanes closed 2 months ago

mrvanes commented 3 months ago

https://github.com/SURFscz/SBS/issues/1314 was accepted as it handles the 404 better. But what should this page actually look like?

FlorisFokkinga commented 3 months ago

A modal seems fine for this situation, similar to https://github.com/SURFscz/SBS/issues/1303#issuecomment-2039917755

oharsta commented 3 months ago

@FlorisFokkinga This is a bigger story than you think as we delete invitations on accept. We can change this, but this has impact in many parts of the code (and functionality). Github (and many other large sites) also display a 404 when you try to access an already accepted invitation. And we do have a custom message for the 404 if the user tried to go to an invitation page. My proposal is to show a modal, but not store the invitations to check how long ago the invitation was accepted. Ok?

FlorisFokkinga commented 3 months ago

Thanks, Github. I give up.

FlorisFokkinga commented 3 months ago

I misread. Sorry for the spam.

Let's simply inform the user the invitation was already used (which is a safe assumption) if it doesn't exist. A modal seems an elegant solution.

oharsta commented 2 months ago

Duplicated by https://github.com/SURFscz/SBS/issues/1263