SURGroup / UQpy

UQpy (Uncertainty Quantification with python) is a general purpose Python toolbox for modeling uncertainty in physical and mathematical systems.
MIT License
267 stars 75 forks source link

Bugfix/kle 2 d #204

Closed lohitv96 closed 1 year ago

lohitv96 commented 1 year ago

Corrected the quasi correlation function computation in KLE 2D sampling code

Description

The original computation of the quasi correlation function was performed by taking diagonals. This is incorrect and a for loop is used.

How Has This Been Tested?

This change introduces more comprehensive tests to test the KLE 2D method. A new test is introduced which compares ensemble correlation value agains the theoretical correlation function.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

Checklist:

Go over all the following points, and put an x in all the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication