search

SUSE-Cloud / automation

Automation scripts for development, testing, and CI
Apache License 2.0
69 stars 139 forks source link

ardana_upgrade needs ardana_extra_vars (SOC-11209) #3923

Closed rtamalin closed 4 years ago

rtamalin commented 4 years ago

The ardana_upgrade role's update_nodes.yml task needs to include the ardana_extra_vars when running the ardana-upgrade.yml playbook to ensure that the relevant override settings that were applied to the Cloud8 deployment are also being applied to upgrade cloud.

JanZerebecki commented 4 years ago

My understanding is too shallow to approve, though I noticed https://github.com/SUSE-Cloud/automation/blob/618a04374c9588227ff68477f51dfc733fa7a2b7/scripts/jenkins/cloud/manual/lib.sh#L336 also has a call to this, which only passes cloudsource, maybe that needs to be changed too?

rtamalin commented 4 years ago

My understanding is too shallow to approve, though I noticed

https://github.com/SUSE-Cloud/automation/blob/618a04374c9588227ff68477f51dfc733fa7a2b7/scripts/jenkins/cloud/manual/lib.sh#L336 also has a call to this, which only passes cloudsource, maybe that needs to be changed too?

Nope, that is a call to the high level playbook which uses the ardana_upgrade role's tasks, where is where this change fixes things, similar to how things are done in the ardana_update role.

For the high level playbooks we need to ensure that we are passing in the @input.yml settings, and any high level overrides that the automation framework uses... But in this case we want to pass overrides to the product playbooks, which are managed within the automation settings, so we are passing them in when we invoke the ardana-upgrade.yml playbook in the product, not when we invoke the automation's equivalent.

rtamalin commented 4 years ago

Have verified using test runs in https://ci.suse.de/blue/organizations/jenkins/openstack-ardana-fergal/detail/openstack-ardana-fergal/41/pipeline/128 and https://ci.suse.de/blue/organizations/jenkins/openstack-ardana-fergal/detail/openstack-ardana-fergal/42/pipeline/146 that this doesn't break things, and appears to make things better.