search

SUSE-Enceladus / azure-li-services

Azure Large Instance Services
GNU General Public License v3.0
7 stars 0 forks source link

Set a VARIANT_ID to be consistent with our cloud images #254

Closed rjschwei closed 4 years ago

schaefi commented 4 years ago

Thanks, I wonder why this setting is not part of the installation of the product package ?

I think the patch part of the version information needs to be raised

rjschwei commented 4 years ago

Din't bump the version as it is not urgent to get this out, since it is only a consistency change.

schaefi commented 4 years ago

Din't bump the version as it is not urgent to get this out, since it is only a consistency change.

ok

@rjschwei Then I only have one question as the description does not answer it. You are setting VARIANT_ID to the os-release file. There are other components on SLE that adds/manages information on this file. I'd like to understand if this extension is something new we from pubcloud just add or if this is something that can conflict with other parts of SLE ?

Sorry since the systemd config file nightmare I'm cautious on these type of changes.

Thanks

schaefi commented 4 years ago

please also remember this is not a classic cloud image. It's sent to Microsoft and they add stuff on top of it. As it basically running SAP HANA workflows and the product information and other data is taken from /etc/os-release I want to be absolutely sure this is not causing trouble

rjschwei commented 4 years ago

Din't bump the version as it is not urgent to get this out, since it is only a consistency change.

ok

@rjschwei Then I only have one question as the description does not answer it. You are setting VARIANT_ID to the os-release file. There are other components on SLE that adds/manages information on this file. I'd like to understand if this extension is something new we from pubcloud just add or if this is something that can conflict with other parts of SLE ?

Sorry since the systemd config file nightmare I'm cautious on these type of changes.

Thanks

Today non of the SUSE products set VARIANT_ID. When looking at os-release as provided by the distro SLES and SLES For SAP are indistinguishable. This let's us from a cloud perspective distinguish between SLES and SLES For SAP in another way than hunting for the baseproduct link. It also allows us to ensure that baseproduct link and image build setup match. This latter part would also apply to the LI/VLI images for testing. For example

if 'sles-sap' in os_release and baseproduct_link != SLES_SAP:
    raise ProductMismatchException()
rjschwei commented 4 years ago

please also remember this is not a classic cloud image. It's sent to Microsoft and they add stuff on top of it. As it basically running SAP HANA workflows and the product information and other data is taken from /etc/os-release I want to be absolutely sure this is not causing trouble

Yes, I am taking the different use case into consideration. There is no guarantee that someone claver will not add VARIANT_ID to our default os-release at some point in the future.

schaefi commented 4 years ago

ok thanks for clarification