SUSE-Enceladus / blue-horizon

web-based user interface to terraforming the public cloud

GNU General Public License v3.0

11 stars 8 forks source link

Rebranding to EOS 4.1 #157

Closed bear454 closed 4 years ago

bear454 commented 4 years ago

MalloZup commented 4 years ago

looks great :heart:

codecov[bot] commented 4 years ago

Codecov Report

Merging #157 into master will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #157   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          706       700    -6     
=========================================
- Hits           706       700    -6

Impacted Files	Coverage Δ
app/helpers/application_helper.rb	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5152059...36f139d. Read the comment docs.

bear454 commented 4 years ago

@arbulu89 can you give this a once-over?

bear454 commented 4 years ago

From d47293b:

bear454 commented 4 years ago

Updated buttons from be81622:

bear454 commented 4 years ago

WRT the width, you need to address that with the EOS maintainers; I'm only implementing the guidance:

https://suse.eosdesignsystem.com/layout

I will be doing something about the dumb jumbotron though, so that may help.

bear454 commented 4 years ago

Rebased on master.

bear454 commented 4 years ago

Results of dcbb4d7:

Screen Shot 2020-10-22 at 17 31 26

bear454 commented 4 years ago

Peek 2020-10-22 17-59

arbulu89 commented 4 years ago

Hi @bear454 , If the width of the screen comes with the EOS branding, I guess we can live with it. Besides that, except the planning in progress gif image is not displayed yet, everything

bear454 commented 4 years ago

Hi @bear454 , If the width of the screen comes with the EOS branding, I guess we can live with it. Besides that, except the planning in progress gif image is not displayed yet, everything

Since I'm going to be working in the plan page within the week, I think I'll just note that for now. Thanks for your help!

cyntss commented 4 years ago

Hey @bear454 , is it okay if I take some screenshots from this PR to showcase Blue Horizon as a success story in EOS?

Btw, I want to say that you have done an amazing job implementing the brand. It looks outstanding.