SUSE-Enceladus / blue-horizon

web-based user interface to terraforming the public cloud

GNU General Public License v3.0

11 stars 8 forks source link

avoid loading local customization in the test environment #170

Closed stefanotorresi closed 3 years ago

stefanotorresi commented 3 years ago

I'm not sure if this is the proper way to go about this, but I don't think the tests should be affected by local customizations.

Another approach could be to set BLUE_HORIZON_CUSTOMIZER to a checked-in file, dedicated to the test environment, but there are no actual customization needed at the moment. I guess we could just put an empty json file somewhere, though.

I'm open to suggestions!

codecov[bot] commented 3 years ago

Codecov Report

Merging #170 (7949176) into master (39114e2) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #170   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          645       645           
=========================================
  Hits           645       645

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39114e2...9f58564. Read the comment docs.

bear454 commented 3 years ago

I prefer the alternative you posted in the description; in general I'd prefer the test suite bend over backwards to fit the app, rather than modifying the app for testing convenience.

stefanotorresi commented 3 years ago

@bear454 makes total sense! Updated accordingly.

bear454 commented 3 years ago

This bit me yesterday, in testing the top menu. Thanks for fixing this!