search

SUSE-Enceladus / blue-horizon

web-based user interface to terraforming the public cloud
GNU General Public License v3.0
11 stars 8 forks source link

Remove delete operation in plan as it is not executed #199

Closed arbulu89 closed 3 years ago

arbulu89 commented 3 years ago

Just removing one line of code that I added by mistake. The truth is that it doesn't impact the app, as the line cannot be executed (the file is always deleted in the cleanup method that is executed always before this).

PD: And the test coverage was not even affected as even the code in the if side is not executed, checking the conditions makes the coverage catch this line...

codecov[bot] commented 3 years ago

Codecov Report

Merging #199 (57cbf5a) into master (1f187cd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #199   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          717       716    -1     
=========================================
- Hits           717       716    -1
Impacted Files Coverage Δ
app/controllers/plans_controller.rb 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f187cd...d90ff86. Read the comment docs.