search

SUSE-Enceladus / blue-horizon

web-based user interface to terraforming the public cloud
GNU General Public License v3.0
11 stars 8 forks source link

Resolve two issues that blocked terraform output #98

Closed bear454 closed 4 years ago

codecov[bot] commented 4 years ago

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines          580       583    +3     
=========================================
+ Hits           580       583    +3
Impacted Files Coverage Δ
app/helpers/authorization_helper.rb 100.00% <ø> (ø)
app/controllers/deploys_controller.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 61c8879...fc24d45. Read the comment docs.

bear454 commented 4 years ago

Per our discussion @jesusbv ... it doesn't make sense to write_output more than once:

  1. the status condition is considered in terms of how to log it, since status is only true upon completion, incomplete results would be logged as error, and that's wrong.
  2. the output grows as the job runs, so every time we wrote output it would redundantly write the prior output again.