Closed rjschwei closed 1 year ago
There's already the option to choose a region and to choose an instance type. It seems the only piece missing is the ability to set --cpu-options AmdSevSnp=enabled
.
It's a slippery slope if we embed a list of SEV capable regions and instance types. We will be constantly chasing that list to keep it up to date. It seems better to let AWS provide an error if an invalid setup is provided and not to duplicate all these error handling features.
We should not embed the specific knowledge into img-proof, I agree. That knowledge should be at some higher level, whatever drives img-proof. In our case this is mash and as such we should have a similar issue for mash.
We need implement/support booting instances in certain regions with certain settings. For example AMD-SEV is only available 2 regions in AWS ATM has certain instance type restrictions and requires special settings during instance launch.