SUSE-Enceladus / img-proof

img-proof provides a command line utility to test images in the Public Cloud
https://img-proof.readthedocs.io/en/latest/
GNU General Public License v3.0
14 stars 7 forks source link

Support hardened images #365

Closed ricardobranco777 closed 9 months ago

ricardobranco777 commented 11 months ago

Fixes https://github.com/SUSE-Enceladus/img-proof/issues/358

smarlowucf commented 9 months ago

Aside from the issue with chattr command I tested this iteration against sles-hardened, sles-sap-hardened and sles and it seems good. I also tested a small instance type vs a high memory instance type to confirm skip happens as expected for low memory instance.

ricardobranco777 commented 9 months ago

Aside from the issue with chattr command I tested this iteration against sles-hardened, sles-sap-hardened and sles and it seems good. I also tested a small instance type vs a high memory instance type to confirm skip happens as expected for low memory instance.

Thanks a lot for your patience.

smarlowucf commented 9 months ago

Looks good, will wait on Robert's re-review before merge.

ricardobranco777 commented 9 months ago

@smarlowucf

smarlowucf commented 9 months ago

@ricardobranco777 can you point to the latest changes in c9d8ad7? The force pushes hide these.

ricardobranco777 commented 9 months ago

@ricardobranco777 can you point to the latest changes in c9d8ad7? The force pushes hide these.

smarlowucf commented 9 months ago

Thanks, having a skip micro is okay with me for now. We need a new issue so the request doesn't get forgotten. And there's still a change request open. @rjschwei I will merge tomorrow unless there's other concerns.

https://github.com/SUSE-Enceladus/img-proof/issues/369

rjschwei commented 9 months ago

Thanks for the contribution @ricardobranco777

smarlowucf commented 9 months ago

Thanks @ricardobranco777