Closed ricardobranco777 closed 9 months ago
Aside from the issue with chattr command I tested this iteration against sles-hardened, sles-sap-hardened and sles and it seems good. I also tested a small instance type vs a high memory instance type to confirm skip happens as expected for low memory instance.
Aside from the issue with chattr command I tested this iteration against sles-hardened, sles-sap-hardened and sles and it seems good. I also tested a small instance type vs a high memory instance type to confirm skip happens as expected for low memory instance.
Thanks a lot for your patience.
Looks good, will wait on Robert's re-review before merge.
@smarlowucf
@ricardobranco777 can you point to the latest changes in c9d8ad7? The force pushes hide these.
@ricardobranco777 can you point to the latest changes in c9d8ad7? The force pushes hide these.
Thanks, having a skip micro is okay with me for now. We need a new issue so the request doesn't get forgotten. And there's still a change request open. @rjschwei I will merge tomorrow unless there's other concerns.
Thanks for the contribution @ricardobranco777
Thanks @ricardobranco777
Fixes https://github.com/SUSE-Enceladus/img-proof/issues/358