search

SUSE-Enceladus / keg

Kiwi Entwicklungs-Gerät (tool to produce kiwi image descriptions)
GNU General Public License v3.0
8 stars 6 forks source link

Fix unit tests of OBS src service module #119

Closed jgleissner closed 1 year ago

jgleissner commented 1 year ago

Fix a previously non functional assertion. Remove a previously non functional assertion for a function call that was not to be executed in that circumstance anyway.

jgleissner commented 1 year ago

CI tests for python 3.6 are broken at the moment (python 3.6 not supported anymore in used platform), looking into it.

rjschwei commented 1 year ago

@jgleissner @apozsuse recently fixed the Python 3.6 unit test issues for other projects we can take the same solution.

apozsuse commented 1 year ago

@jgleissner @apozsuse recently fixed the Python 3.6 unit test issues for other projects we can take the same solution.

It was actually Sean that fixed it for some repo (and I extended to other repos having the same issues).

The problem is that python 3.6 is not available any longer in ubuntu:latest container (the one we use for the ci/cd pipeline), and we just splitted the test for 3.6 in a separate job running on ubuntu:20.04.

Here you can find a PR with that change.

jgleissner commented 1 year ago

The problem is that python 3.6 is not available any longer in ubuntu:latest container (the one we use for the ci/cd pipeline), and we just splitted the test for 3.6 in a separate job running on ubuntu:20.04.

That's what I did too, just a little differently.