SUSE-Enceladus / keg

Kiwi Entwicklungs-Gerät (tool to produce kiwi image descriptions)
GNU General Public License v3.0
8 stars 6 forks source link

Better spacing in config.sh #76

Closed jgleissner closed 3 years ago

jgleissner commented 3 years ago

Do not append newlines at the end of sections. Insert newline between if blocks. Insert newline between scriptlets.

jgleissner commented 3 years ago

pytest is failing because test/data/keg_output_xml/config.xml doesn't match the generated output (anymore). This file was already changed in commit 69a09f720458aee0f454701bea8d95e0c8f795a0 to adjust for a change of indentation step width in kiwi. It appears this has changed once again. Maybe we should use xmldiff to compare the files so at least the test won't fall over anymore over changes in whitespaces.

jgleissner commented 3 years ago

I'll fix this in a separate PR, as it's unrelated to the changes in this one.