Closed alexandrevicenzi closed 1 month ago
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1420
Changes pushed to branch Tumbleweed-1420
as commit a39c3234b946ad817c2a9b4f37d49477405b854e
Build succeeded ✅
Build succeeded ✅
To run BCI-tests against this PR, use the following command:
OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1420/ tox -- -n auto
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️ ⚠️⚠️ Project and Branch have been deleted ⚠️⚠️
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1420
Changes pushed to branch 6-1420
as commit 2821eb726767f995b5bbc9f41a6fce4c83db33b2
Build succeeded ✅
Build succeeded ✅
To run BCI-tests against this PR, use the following command:
OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1420/ tox -- -n auto
The readme is missing the standard footer & header.
Yes, because .NET does not belong in bci_build. I have no way of reusing templates from there and I would need to duplicate it, create some hackery, or move .NET into bci_build as a package like others.
What do you suggest @dcermak @dirkmueller?
Also, would it make it sense to have separate templates for the images? The current template looks more like three templates with a bit of common content.
Yes, it could be split, but again, it needs a bit more hackery to get it working, unless it becomes a bci_build package.
The readme is missing the standard footer & header.
Yes, because .NET does not belong in bci_build. I have no way of reusing templates from there and I would need to duplicate it, create some hackery, or move .NET into bci_build as a package like others.
What do you suggest @dcermak @dirkmueller?
I haven't tried this, but I think the following should work:
src/bci_build/package/dotnet-sdk/README.md.j2
src/bci_build/package/dotnet-{runtime,aspnet}/README.md.j2
to the first templatethen the standard readme reading code should pick it up and you should have access to additional footer & headers.
Also, would it make it sense to have separate templates for the images? The current template looks more like three templates with a bit of common content.
Yes, it could be split, but again, it needs a bit more hackery to get it working, unless it becomes a bci_build package.
I don't think that you need to have it in the bci_build
package for the template reader to pick it up.
@dcermak no hackery needed. It seems that the template is picked from the correct place. I also split into multiple templates and created a few partials to be imported where text was duplicated.
This is related to #993.