SUSE / BCI-tests

This repository contains the tests for the SUSE Base Container Images
Apache License 2.0
10 stars 22 forks source link

Test mariadb version upgrade #504

Open dirkmueller opened 5 months ago

dirkmueller commented 5 months ago

Sle 15.5 to 15.6 is going to change the mariadb version and the docker entry point is handling version updates by going through a data migration workflow.

We do not have a test for that and we know the current state was broken because the upstream developers notified us about that issue.

We need to test an upgrade scenario

alexandrevicenzi commented 5 months ago

Is the test scenario in mind around mariadb-upgrade?

In theory, SLE is not going to move to a version where mariadb-upgrade would not work. If you follow the SLE upgrade paths, you can migrate from SLE 12 MariaDB to SLE 15 with no issues, as long as you always run mariadb-upgrade in each SLE migration.

dirkmueller commented 5 months ago

@alexandrevicenzi the entrypoint script performs the upgrade itself based on some logic and extra code paths that were broken. we're not testing them. we should be testing them prior to playing out the 15.6 upgrade.

see docker_mariadb_upgrade in the entrypoint.sh

grooverdan commented 5 months ago

As your new entrypoint is fixed, I don't think you are in a bad position. The mariadb-upgrade checks the file $DATADIR/mariadb-upgrade-info ( or mysql_upgrade_info) for the version that was previously installed/upgraded. The old invalid version number in the entrypoint was only used as a pre-check comparison if an upgrade was needed and wasn't actually stored anywhere.