SUSE / BCI-tests

This repository contains the tests for the SUSE Base Container Images
Apache License 2.0
10 stars 22 forks source link

Fix handling of the ironbank base container #555

Closed dirkmueller closed 1 week ago

dirkmueller commented 3 months ago

The ironbank base container is a fips container but actually called bci-base.

dirkmueller commented 3 months ago

Would it maybe make the handling a bit simpler if we added bci-base to BASE_FIPS_CONTAINERS if the target is "dso"?

not really, because we expect BASE_CONTAINER to be always existing and exactly one container everywhere. I've pushed an additional commit to do what you're asking for. I think the previous solution was simpler.

dcermak commented 1 week ago

Would it maybe make the handling a bit simpler if we added bci-base to BASE_FIPS_CONTAINERS if the target is "dso"?

not really, because we expect BASE_CONTAINER to be always existing and exactly one container everywhere. I've pushed an additional commit to do what you're asking for. I think the previous solution was simpler.

You're right, the new solution is pretty complicated. The previous one was better