search

SUSE / BCI-tests

This repository contains the tests for the SUSE Base Container Images
Apache License 2.0
8 stars 21 forks source link

Reject packages with a SUSE-Firmware license in the BCI repo #587

Closed dirkmueller closed 1 week ago

dirkmueller commented 2 weeks ago
dirkmueller commented 1 week ago

tiny nit: atm it's not possible to find out which package is the offender from the logs. This could be worked around by not using grep -c and instead only grep and then counting the lines in python (should be reasonably cheap)

doesn't work because the package name is not on the line that is being greped, but somewhere around it. it's not difficult to find the offender, so this should be fine.

dcermak commented 1 week ago

Dirk Mueller @.***> writes:

tiny nit: atm it's not possible to find out which package is the offender from the logs. This could be worked around by not using grep -c and instead only grep and then counting the lines in python (should be reasonably cheap)

doesn't work because the package name is not on the line that is being greped, but somewhere around it. it's not difficult to find the offender, so this should be fine.

Ah, right! Fair enough then