Is deepsea.user salt:salt mandatory?

noelmcloughlin commented 5 years ago

Description of Issue/Question

After running make install on Ubuntu, there is no salt:salt user/group pair created.

However stage 2 fails so maybe they are needed?

Setup

# salt-run state.orch ceph.stage.2
[WARNING ] role-mon/cluster/mon*.sls matched no files
[WARNING ] role-mgr/cluster/mon*.sls matched no files
[WARNING ] role-mds/cluster/mds*.sls matched no files
[WARNING ] role-igw/cluster/igw*.sls matched no files
[WARNING ] role-rgw/cluster/rgw*.sls matched no files
[WARNING ] role-ganesha/cluster/ganesha*.sls matched no files
[WARNING ] role-storage/cluster/data*.sls matched no files
deepsea_minions          : valid
yaml_syntax              : valid
[WARNING ] role-mon/cluster/mon*.sls matched no files
[WARNING ] role-mgr/cluster/mon*.sls matched no files
[WARNING ] role-mds/cluster/mds*.sls matched no files
[WARNING ] role-igw/cluster/igw*.sls matched no files
[WARNING ] role-rgw/cluster/rgw*.sls matched no files
[WARNING ] role-ganesha/cluster/ganesha*.sls matched no files
[WARNING ] role-storage/cluster/data*.sls matched no files
public network           : 172.16.8.0/24
cluster network          : 10.0.2.0/24
[ERROR   ] {'out': 'highstate', 'ret': {'ubuntu1804.localdomain': ["Rendering SLS 'base:ceph.admin.key.default' failed: Jinja variable 'salt.utils.templates.AliasedLoader object' has no attribute 'deepsea.user'"]}}
ubuntu1804.localdomain_master:
  Name: push.proposal - Function: salt.runner - Result: Changed Started: - 17:16:45.796683 Duration: 252.018 ms
  Name: refresh_pillar1 - Function: salt.state - Result: Changed Started: - 17:16:46.048833 Duration: 337.359 ms
  Name: advise.networks - Function: salt.runner - Result: Changed Started: - 17:16:46.386295 Duration: 613.737 ms
  Name: install ceph packages - Function: salt.state - Result: Clean Started: - 17:16:47.000148 Duration: 4935.298 ms
----------
          ID: admin key
    Function: salt.state
      Result: False
     Comment: Run failed on minions: ubuntu1804.localdomain
     Started: 17:16:51.935739
    Duration: 4758.604 ms
     Changes:   
              ubuntu1804.localdomain:
                  Data failed to compile:
              ----------
                  Rendering SLS 'base:ceph.admin.key.default' failed: Jinja variable 'salt.utils.templates.AliasedLoader object' has no attribute 'deepsea.user'

Summary for ubuntu1804.localdomain_master
------------
Succeeded: 4 (changed=3)
Failed:    1
------------
Total states run:     5
Total run time:  10.897 s
root@ubuntu1804:/root# rm -fr /var/cache/salt/*; systemctl restart salt-master salt-minion salt-api
root@ubuntu1804:/root# find /var/cache/salt/master/jobs -user root -exec chown salt:salt {} \;
chown: invalid user: 'salt:salt'

Steps to Reproduce Issue

(Include debug logs if possible and relevant.)

root@ubuntu1804:/root/# salt-run deepsea.version
0.0.0
root@ubuntu1804:/root/# /usr/local/bin/deepsea --version
deepsea 0.0.0
root@ubuntu1804:/root/# dpkg-query --list | grep salt
ii  salt-api                              2019.2.0+ds-1                     all          Generic, modular network access system
ii  salt-common                           2019.2.0+ds-1                     all          shared libraries that salt requires for all packages
ii  salt-master                           2019.2.0+ds-1                     all          remote manager to administer servers via salt
ii  salt-minion                           2019.2.0+ds-1                     all          client package for salt, the distributed remote execution system

noelmcloughlin commented 5 years ago

I can replicate this issue on Ubuntu. There must be some step missing in README.

noelmcloughlin commented 5 years ago

Same issue on archlinux.

                  chown: invalid user: 'salt:salt'
                  Job for salt-api.service failed because the control process exited with error code.
                  See "systemctl status salt-api.service" and "journalctl -xe" for details.
                  make: *** [Makefile:977: install] Error 1

jschmid1 commented 5 years ago

This is due to SLES/openSUSE creating salt:salt for the salt-master

SUSE / DeepSea