search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
162 stars 75 forks source link

flip logic for /available/ disks filtering #1722

Closed jschmid1 closed 5 years ago

jschmid1 commented 5 years ago

Signed-off-by: Joshua Schmid jschmid@suse.de

Fixes #1721

Checklist:

jschmid1 commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 1ede59c72cac740b97e0fdf6a427ca89c5cf47f1 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/262/

jschmid1 commented 5 years ago

that's new @shyukri 

2019-08-13T09:53:14.313 INFO:teuthology.orchestra.run.target192168000147:Running: 'sudo mkfs.ext4 -F /dev/vdd; sudo mount /dev/vdd /mnt'
2019-08-13T09:53:14.533 INFO:teuthology.orchestra.run.target192168000147.stderr:mke2fs 1.43.8 (1-Jan-2018)
2019-08-13T09:53:14.535 INFO:teuthology.orchestra.run.target192168000147.stderr:/dev/vdd is apparently in use by the system; will not make a filesystem here!
2019-08-13T09:53:14.614 INFO:teuthology.orchestra.run.target192168000147.stderr:mount: /mnt: unknown filesystem type 'LVM2_member'.

maybe add a lvremove/vgremove/pvremove or even a sgdisk -Z before?

jschmid1 commented 5 years ago

dashboard e2e tests are ok to fail currently (I guess)

shyukri commented 5 years ago

that's new @shyukri

2019-08-13T09:53:14.313 INFO:teuthology.orchestra.run.target192168000147:Running: 'sudo mkfs.ext4 -F /dev/vdd; sudo mount /dev/vdd /mnt'
2019-08-13T09:53:14.533 INFO:teuthology.orchestra.run.target192168000147.stderr:mke2fs 1.43.8 (1-Jan-2018)
2019-08-13T09:53:14.535 INFO:teuthology.orchestra.run.target192168000147.stderr:/dev/vdd is apparently in use by the system; will not make a filesystem here!
2019-08-13T09:53:14.614 INFO:teuthology.orchestra.run.target192168000147.stderr:mount: /mnt: unknown filesystem type 'LVM2_member'.

maybe add a lvremove/vgremove/pvremove or even a sgdisk -Z before?

I've not seen it on https://github.com/SUSE/ceph/pull/322

jschmid1 commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit a3914cd32c705d06d97298d98cd94f0faa16f3ab is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/264/

kshtsk commented 5 years ago

@susebot run teuthology using wip-qa-drive-replace-fix from https://github.com/shyukri/ceph

susebot commented 5 years ago

Commit a3914cd32c705d06d97298d98cd94f0faa16f3ab is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/265/

shyukri commented 5 years ago

Only the dashboard tests are failing, Drive replacement one lists correctly only one device as expected:

2019-08-14T15:59:44.379 INFO:teuthology.orchestra.run.target192168000115.stdout:Device Path               Size         rotates available Model name
2019-08-14T15:59:44.379 INFO:teuthology.orchestra.run.target192168000115.stdout:/dev/vdc                  10.00 GB     True    True
2019-08-14T15:59:44.379 INFO:teuthology.orchestra.run.target192168000115.stdout:/dev/vda                  40.00 GB     True    False

....
sudo salt-run disks.c_v_commands
...
ceph-volume lvm batch --no-auto /dev/vdc --yes --osd-ids 2
shyukri commented 5 years ago

@susebot run teuthology for suite deepsea:tier2:drive-replacement using wip-qa-drive-replace-fix from https://github.com/shyukri/ceph

susebot commented 5 years ago

Commit a3914cd32c705d06d97298d98cd94f0faa16f3ab is OK for suite deepsea:tier2:drive-replacement. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/266/