Added data tag in cephdisks/dg for filestore OSDs

[gekios]

Proposed solution for "#Bug 1145600 - Unable to remove/rebuild Filestore OSDs through Deepsea", I also added it on dg.py since I saw that it's applied there as well.

Description: Add the 'ceph.type' tag for filestore OSDs

---

Checklist:

• [ ] Added unittests and or functional tests
• [ ] Adapted documentation
• [x] Referenced issues or internal bugtracker
• [x] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

[jschmid1]

The linter complained with:

16:36:38 ************* Module srv.salt._modules.cephdisks
16:36:38 E:209, 0: PEP8 E128: continuation line under-indented for visual indent (continuation-line-under-indented-for-visual-indent)
16:36:38 E:208, 0: PEP8 E502: the backslash is redundant between brackets (the-backslash-is-redundant-between-brackets)
16:36:38 ************* Module srv.salt._modules.dg
16:36:38 E:904, 0: PEP8 E128: continuation line under-indented for visual indent (continuation-line-under-indented-for-visual-indent)
16:36:38 E:903, 0: PEP8 E502: the backslash is redundant between brackets (the-backslash-is-redundant-between-brackets)

[gekios]

My bad, fixed the lint issues.

[jschmid1]

This looks good. I'm not sure what this is used for but should we also add the other types here? The others would be journal, wal, db and lockbox.

This method finds the data device only. It'd great to modify this call to return a structure close to:

{'data': '/dev/foo',
 'journal': None,
 'wal': '/dev/wal',
 'db': '/dev/wal',
}

Since we're getting the lv_tags from ceph-volume, I assume the right place for such a metadata query operation would belong to ceph-volume :thinking:

[jschmid1]

@susebot run teuthology

[susebot]

Commit c89a914e3e14eee75ecdbaa44006b7eeb887a390 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/267/

[jschmid1]

test failures are unrelated .. dashboard end2end tests