Fixup rpmbuild in Makefile

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.

GNU General Public License v3.0

161 stars 75 forks source link

Fixup rpmbuild in Makefile #1732

Closed mgfritch closed 5 years ago

mgfritch commented 5 years ago

Description:

The 'make tarball' and 'make rpm' targets were failing in various ways when run as user 'root' and also when run as a 'non-root' user.

Checklist:

[ ] Added unittests and or functional tests
[ ] Adapted documentation
[ ] Referenced issues or internal bugtracker
[ ] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

jschmid1 commented 5 years ago

adding @smithfarm for Make/spec file sorcery

smithfarm commented 5 years ago

This PR doesn't change the spec file, so nothing for me to review, but I can say the following:

I vaguely recall that "make rpm" did not work when run as root.

The proof is in the pudding - the deepsea-make-rpm Jenkins test passed. We should also run teuthology on this, since (IIRC) the Jenkins job which runs teuthology first builds RPMs using "make rpm".

kshtsk commented 5 years ago

Yes I think running teuthology is reasonable.

mgfritch commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 233e41f2dbd916fe7802c9a035ccbf3cf81f5c23 is OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/279/

jschmid1 commented 5 years ago

we need a rebase here, but I think this looks reasonable. I can't 100% tell if the changes will cause any inconvenience due to my lack of knowledge in the spec/make land :/

mgfritch commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 59246a370c51304fd9b570193f08fd757f0d58d3 is OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/280/