search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
160 stars 75 forks source link

Fixup unit/lint tests #1752

Closed mgfritch closed 4 years ago

mgfritch commented 4 years ago

Clean-up for 'make test' and 'make lint' targets:

Checklist:

mgfritch commented 4 years ago

@susebot run teuthology

mgfritch commented 4 years ago

@smithfarm @kshtsk The storage-ci/deepsea-make-lint test failed, because the user is not included in the sudoers file. But, the storage-ci/deepsea-make-test does succeed, because that test has an additional step that will add the user to the sudoers file ...

Both tests are using the python tox project, any reason why we cannot have a similar set of setup scripts for both tests?

Likewise, I noticed the storage-ci/deepsea-make-lint tests are using python2 .. should this be switched to use python3?

susebot commented 4 years ago

Commit de06c94ec2099a601c14a7c4c9564d7de37abbd3 is OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/286/

jschmid1 commented 4 years ago

The make lint job failed with. Would you have a look @mgfritch 

00:35:36 ([ -z "salt-api python3-setuptools python3-click python3-tox python3-configobj gcc python3-devel" ] || sudo --preserve-env zypper -n install salt-api python3-setuptools python3-click python3-tox python3-configobj gcc python3-devel)
00:35:36 
00:35:36 We trust you have received the usual lecture from the local System
00:35:36 Administrator. It usually boils down to these three things:
00:35:36 
00:35:36     #1) Respect the privacy of others.
00:35:36     #2) Think before you type.
00:35:36     #3) With great power comes great responsibility.
00:35:36 
00:35:36 sudo: no tty present and no askpass program specified
00:35:36 make: *** [Makefile:984: python3-setuptools] Error 1
smithfarm commented 4 years ago

@mgfritch I have nothing to do with, and know nothing about, the deepsea-make-lint test. Sorry.

jschmid1 commented 4 years ago

retest this please

kshtsk commented 4 years ago

@smithfarm @kshtsk The storage-ci/deepsea-make-lint test failed, because the user is not included in the sudoers file. But, the storage-ci/deepsea-make-test does succeed, because that test has an additional step that will add the user to the sudoers file ...

Both tests are using the python tox project, any reason why we cannot have a similar set of setup scripts for both tests?

Likewise, I noticed the storage-ci/deepsea-make-lint tests are using python2 .. should this be switched to use python3?

you should change your test, the lint test should have nothing to do with sudoers right, do you have any reasonable point of having static analysis tool access? I have tons to not give it

mgfritch commented 4 years ago

closed due to lack of interest