search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
160 stars 75 forks source link

iscsi: SSL enabled deployment by default #1754

Closed rjfd closed 4 years ago

rjfd commented 4 years ago

Fixes: bsc#1134536

This PR makes the deployment of iscsi (ceph-iscsi) service to have SSL enabled by default for its REST API.

Signed-off-by: Ricardo Dias rdias@suse.com

rjfd commented 4 years ago

@jschmid1 can you help me with the fix for the unit test failure? I don't understand why the changes in this PR make the test fail.

jschmid1 commented 4 years ago

@jschmid1 can you help me with the fix for the unit test failure? I don't understand why the changes in this PR make the test fail.

@rjfd please see my inline comment: https://github.com/SUSE/DeepSea/pull/1754/files#r325565229

rjfd commented 4 years ago

tests fixed

jschmid1 commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 1a200d6b7fdf304098f21c9899ff9d229295f748 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/296/

jschmid1 commented 4 years ago

jenkins is broken currently as it seems @kshtsk

kshtsk commented 4 years ago

jenkins is broken currently as it seems @kshtsk

not a jenkins, it is infra issues, no internet connection

+ rsync -av --rsync-path 'mkdir -p /mnt/logs/artifacts/jenkins/deepsea-pr/deepsea:tier2/296 && rsync' repo/ teuthology@10.86.0.120:/mnt/logs/artifacts/jenkins/deepsea-pr/deepsea:tier2/296
ssh: connect to host 10.86.0.120 port 22: Connection timed out
rsync: connection unexpectedly closed (0 bytes received so far) [sender]
rsync error: unexplained error (code 255) at io.c(235) [sender=3.1.3]
kshtsk commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 1a200d6b7fdf304098f21c9899ff9d229295f748 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/307/

jschmid1 commented 4 years ago

The CI detected a failure in iscsi_smoke_test.sh. Running again to verify.

jschmid1 commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 1a200d6b7fdf304098f21c9899ff9d229295f748 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/308/

rjfd commented 4 years ago

@jschmid1 the failure is real, I need to update iscsi_smoke_test.sh to make HTTPS requests to the gateway.

@smithfarm which branch from SUSE/ceph should I target the PR to fix the smoke test script?

rjfd commented 4 years ago

retest this please

jschmid1 commented 4 years ago

failed to copy files: failed to copy directory: Error processing tar file(exit status 1): write /.git/refs/remotes/origin/pr/884/head: no space left on device @kshtsk

kshtsk commented 4 years ago

failed to copy files: failed to copy directory: Error processing tar file(exit status 1): write /.git/refs/remotes/origin/pr/884/head: no space left on device @kshtsk

yeah, I saw this... issue should has been fixed a couple of hours ago, try again

rjfd commented 4 years ago

retest this please

smithfarm commented 4 years ago

@susebot run teuthology deepsea/tier2/igw

susebot commented 4 years ago

Commit 99488dff9efb113d614d781031efe977b88ed01d is OK for suite deepsea/tier2/igw. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/314/