search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

[SES5] Simplify management of tuned #1783

Closed swiftgist closed 5 years ago

swiftgist commented 5 years ago

Disassociate the specific role names from their purpose. Considering that multiple roles can be assigned to a minion, applying a ceph-osd profile to a gateway or having identical profiles for each role is unnecessary.

Signed-off-by: Eric Jackson ejackson@suse.com bnc: 1140723 Port: #1782

Checklist:

jschmid1 commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 0a715164d7707f0b3af5ea75016fc97903a27bbf is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/343/

jschmid1 commented 5 years ago

what's the status here @swiftgist

swiftgist commented 5 years ago

Waiting on the resolution of #1782

swiftgist commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 4a8fe514a4c142a56a15df7f64f0ca5e3652ec32 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/370/

swiftgist commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit cd64e137925172a5beb39d14eb6ee8e819c46e1f is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/371/

jschmid1 commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit cd64e137925172a5beb39d14eb6ee8e819c46e1f is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/372/

jschmid1 commented 5 years ago

this is a legit error @swiftgist 

2019-11-15T11:05:02.249 INFO:teuthology.orchestra.run.target192168000081:Running: "sudo bash -c 'DEV_ENV=true timeout 60m deepsea --log-file=/var/log/salt/deepsea.log --log-level=debug salt-run state.orch ceph.stage.3 --simple-output'"
2019-11-15T11:05:02.781 INFO:teuthology.orchestra.run.target192168000081.stdout:Starting stage: ceph.stage.3
2019-11-15T11:05:05.261 INFO:teuthology.orchestra.run.target192168000081.stdout:Parsing stage ceph.stage.3 steps... fail
2019-11-15T11:05:05.261 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.262 INFO:teuthology.orchestra.run.target192168000081.stdout:An error occurred while rendering the stage:
2019-11-15T11:05:05.262 INFO:teuthology.orchestra.run.target192168000081.stdout:    ceph.stage.3
2019-11-15T11:05:05.262 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.262 INFO:teuthology.orchestra.run.target192168000081.stdout:Error description:
2019-11-15T11:05:05.263 INFO:teuthology.orchestra.run.target192168000081.stdout:  - Rendering SLS 'base:ceph.stage.3.core.default' failed: Jinja syntax error: no filter named 'difference'; line 160
2019-11-15T11:05:05.263 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.263 INFO:teuthology.orchestra.run.target192168000081.stdout:    ---
2019-11-15T11:05:05.263 INFO:teuthology.orchestra.run.target192168000081.stdout:    [...]
2019-11-15T11:05:05.263 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.264 INFO:teuthology.orchestra.run.target192168000081.stdout:    {% set deepsea_minions = salt['saltutil.runner']('deepsea_minions.matches') %}
2019-11-15T11:05:05.264 INFO:teuthology.orchestra.run.target192168000081.stdout:    {% set mons = salt['saltutil.runner']('select.minions', roles='mon') %}
2019-11-15T11:05:05.264 INFO:teuthology.orchestra.run.target192168000081.stdout:    {% set mgrs = salt['saltutil.runner']('select.minions', roles='mgr') %}
2019-11-15T11:05:05.264 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.264 INFO:teuthology.orchestra.run.target192168000081.stdout:    {% set throughput_minions = deepsea_minions | difference(mons) | difference(mgrs) | join(',') %}    <======================
2019-11-15T11:05:05.264 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.265 INFO:teuthology.orchestra.run.target192168000081.stdout:
2019-11-15T11:05:05.265 INFO:teuthology.orchestra.run.target192168000081.stdout:    {% if throughput_minions != "" %}
2019-11-15T11:05:05.265 INFO:teuthology.orchestra.run.target192168000081.stdout:    throughput tuned:
2019-11-15T11:05:05.265 INFO:teuthology.orchestra.run.target192168000081.stdout:      salt.state:
2019-11-15T11:05:05.266 INFO:teuthology.orchestra.run.target192168000081.stdout:    [...]
2019-11-15T11:05:05.266 INFO:teuthology.orchestra.run.target192168000081.stdout:    ---
swiftgist commented 5 years ago

Apparently, difference wasn't added until Salt 2017.07 docs.saltstack.com/en/latest/topics/jinja/index.html#difference

Let me see what other options there are.

jschmid1 commented 5 years ago

this is blocking us from releasing a new deepsea for 5.5. We should bump up the priority here

swiftgist commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 64de58944a92ff1c1b5bf9e7d611cbbb94b7b7ff is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/378/

swiftgist commented 5 years ago

@susebot run teuthology

susebot commented 5 years ago

Commit 1c86ddb1379b7b2140f01f373e6b6a08b4dee185 is OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://ci.ses.suse.de:8080/job/pr-deepsea/382/