pylintrc: Disable W8410 check

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.

GNU General Public License v3.0

161 stars 75 forks source link

Closed gekios closed 4 years ago

gekios commented 4 years ago

I propose disabling W8410 - 3rd-party-module-not-gated, in order to fix the CI failures that got introduced by server upgrade to Leap 15.1.

Signed-off-by: Georgios Kyratsas gkyratsas@suse.com

Description:

Checklist:

[ ] Added unittests and or functional tests
[ ] Adapted documentation
[ ] Referenced issues or internal bugtracker
[ ] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

jan--f commented 4 years ago

huh any idea why pylint suddenly thinks os is a 3rd party module?

gekios commented 4 years ago

Yeah actually I noticed this as well and after googling a bit it seems to be missing from all the lists that makeknown_std_modules https://github.com/saltstack/salt-pylint/blob/37d7a63ea808fd42c68378ddf6a5429570c800ac/saltpylint/thirdparty.py#L68

gekios commented 4 years ago

Hmmm, I added every module that it was complaining about in allowed-3rd-party-modules and it passed but is this the right approach?

jschmid1 commented 4 years ago

probably not, but it lets us move ahead :>