SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

Do not remove ceph-grafana-dashboards on mgr nodes #1834

Closed swiftgist closed 4 years ago

swiftgist commented 4 years ago

The ceph-mgr-dashboard requires the ceph-grafana-dashboards, so only uninstall the ceph-grafana-dashboards from minions that have neither grafana nor mgr roles.

Signed-off-by: Eric Jackson ejackson@suse.com bsc: 1168359


Checklist:

swiftgist commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 9abb2f0803fc118e664b9bd205fac2cf1b125ca1 is OK for suite deepsea:tier2. Check tests results in the Jenkins job: http://storage-ci.suse.de/job/pr-deepsea/433/

LenzGr commented 4 years ago

The ceph-mgr-dashboard requires the ceph-grafana-dashboards,

Note that this is not required from a package management perspective. Ceph Dashboard is completely independent of the Grafana Dashboards. But they need to be installed on the same node where Grafana is running, so Grafana can use and render them.

swiftgist commented 4 years ago

This is the current behavior from zypper

 # zypper remove ceph-grafana-dashboards
Reading installed packages...
Resolving package dependencies...

The following 2 packages are going to be REMOVED:
ceph-grafana-dashboards ceph-mgr-dashboard

2 packages to remove.
After the operation, 83.7 MiB will be freed.
Continue? [y/n/v/...? shows all options] (y):

So, when DeepSea removes ceph-grafana-dashboards, ceph-mgr-dashboard comes with it.

jschmid1 commented 4 years ago

So, when DeepSea removes ceph-grafana-dashboards, ceph-mgr-dashboard comes with it.

This doesn't seem desirable. Any recommendations to fix this @swiftgist @LenzGr ?

swiftgist commented 4 years ago

@jschmid1 Well, that's what this PR does within what can be done in Salt. It's working for support.