aa-teardown can fail if apparmor is disabled on the boot command line

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.

GNU General Public License v3.0

161 stars 75 forks source link

aa-teardown can fail if apparmor is disabled on the boot command line #1846

Closed swiftgist closed 4 years ago

swiftgist commented 4 years ago

Signed-off-by: Eric Jackson ejackson@suse.com bnc: 1174536

Checklist:

[ ] Added unittests and or functional tests
[ ] Adapted documentation
[x] Referenced issues or internal bugtracker
[ ] Ran integration tests successfully (trigger with "@susebot run teuthology" in a GitHub comment; see the wiki for more information)

swiftgist commented 4 years ago

The onfail is like a goto... so adding the failure condition for the binary being present but disabled in the kernel command line. This causes the state to succeed in that case, but leaves the original behavior intact.

jan--f commented 4 years ago

huh...is there a naming conflict or version issue? Cause https://docs.saltstack.com/en/latest/ref/states/requisites.html#onfail reads differently to me. Or at least to goto-like aspect isn't mentioned.

swiftgist commented 4 years ago

Take a look at the whole file, it's the same behavior with the previous step. Also, I did have Martin test in his environment and the state succeeded. Would you have another solution?

jan--f commented 4 years ago

Well who am I to argue with successful testing :) Only alternative might be adding jinja and I'm always up for avoiding that.

jschmid1 commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 141eedb073e0b02679acc1992a71b325bbbde57f is OK for suite deepsea:tier2. Check tests results in the Jenkins job: https://storage-ci.suse.de/job/pr-deepsea/458/