SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

validate: check if domain grain is set #1848

Closed jschmid1 closed 4 years ago

jschmid1 commented 4 years ago

Signed-off-by: Joshua Schmid jschmid@suse.de

If a user misconfigured their fqdn like so:

# hostname --fqdn
target-00

salt can't determine the domain

In [2]: 'target-00'.partition('.')[::2]                                         
Out[2]: ('target-00', '')

And we fail here

with:

Exception: According to the 'domain' grain, the cluster does not have a DNS domain configured

This is probably too late. Also the error message is not very descriptive.

My concern is that we break existing (working) installations that don't use SSL (yet).

Maybe raising a warning instead of an error is also fine?


Checklist:

kshtsk commented 4 years ago

Related ticket: https://jira.suse.com/browse/SES-2122

jschmid1 commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 043bd60812d0a31b0ebbcca29ef37171d83f784e is OK for suite deepsea:tier2. Check tests results in the Jenkins job: https://storage-ci.suse.de/job/pr-deepsea/473/