search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
160 stars 75 forks source link

Fix case where remove_subnet_list is None #1851

Closed swiftgist closed 4 years ago

swiftgist commented 4 years ago

Signed-off-by: Eric Jackson ejackson@suse.com

Found in the field. When remove_subnet_list is None, the error is 

  File "/srv/modules/runners/net.py", line 470, in _remove_minion_exclude
    remove_subnets = remove_subnet_list.split(",")
AttributeError: 'NoneType' object has no attribute 'split'

Checklist:

swiftgist commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit b0e7f6ac7fb94221545bcb9577f95da610d65bb7 is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: https://storage-ci.suse.de/job/pr-deepsea/474/

swiftgist commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 767a05f87d3943b40786675c18a9694b89872c0a is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: https://storage-ci.suse.de/job/pr-deepsea/475/

jschmid1 commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 767a05f87d3943b40786675c18a9694b89872c0a is NOT OK for suite deepsea:tier2. Check tests results in the Jenkins job: https://storage-ci.suse.de/job/pr-deepsea/476/

swiftgist commented 4 years ago

looks good!

Is that something we have to update in ceph-salt as well @swiftgist ?

Already done. github.com/ceph/ceph-salt/blob/master/ceph-salt-formula/salt/_runners/network.py#L391-L394

jschmid1 commented 4 years ago

@susebot run teuthology

susebot commented 4 years ago

Commit 767a05f87d3943b40786675c18a9694b89872c0a is OK for suite deepsea:tier2. Check tests results in the Jenkins job: https://storage-ci.suse.de/job/pr-deepsea/477/