search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

osd: handle `ceph osd ok-to-stop` output from ceph v14.2.22 #1880

Closed tserong closed 3 years ago

tserong commented 3 years ago

Prior to https://github.com/ceph/ceph/commit/a45bfebb, the ceph osd ok-to-stop command output a long, human readable string. DeepSea was looking at this string to see if OSDs really were OK to stop. Since that commit, the output of this command is now a chunk of JSON, which obviously can't work with that string comparison, so let's try to parse the JSON first, in case we're using the latest Nautilus release, and if that fails, fall back to the previous check in case we're still running against an older Ceph.

Signed-off-by: Tim Serong tserong@suse.com

tserong commented 3 years ago

This made it through my manual testing against ceph 14.2.21 and 14.2.22 (salt-run state.orch ceph.functests.1node.replace.delay succeeded and salt-run state.orch ceph.functests.1node.replace.multiple failed, when run against both those versions of ceph, which is the outcome I expected).