SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

Extra information when PGs take too long to be in active+clean state #1888

Closed 0xavi0 closed 2 years ago

0xavi0 commented 2 years ago

When running rebuild.node it waits for PGs to be in the active+clean state. If PGs are, for example scrubbing, the user only gets the message: "Waiting for PGs to recover..."

This branch adds extra information, showing the actual state of PGs and, in the case that they're scrubbing, it sugests to disable scrubbing and trying.

The return value of quiescent method has been changed to return (in addition to the return result) a message that the rebuild runner can display to the user as a warning.

Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1194807 Signed-off-by: Xavi Garcia xavi.garcia@suse.com

tserong commented 2 years ago

Alright, I finally managed to get a test of this with an actual scrub running, and I reckon we're good :-) Can you please squash this back to a single commit?