search

SUSE / DeepSea

A collection of Salt files for deploying, managing and automating Ceph.
GNU General Public License v3.0
161 stars 75 forks source link

Don't use punctuation when generating dashboard admin password #1891

Closed tserong closed 2 years ago

tserong commented 2 years ago

If the string generated by random.get_str includes punctuation, it can break the parsing of the jinja template and/or screw up the line that echoes the password into ceph dashboard ac-user-create. Salt 3004 added the ability to limit what characters are used in the password, so let's turn off punctuation to avoid this problem.

Fixes: https://bugzilla.suse.com/show_bug.cgi?id=1200794 Signed-off-by: Tim Serong tserong@suse.com

tserong commented 2 years ago

Ideally we'd have proper quoting around dashboard_pw whenever it's used, but this should be sufficient for all the use left in DeepSea.

That was my thinking too